On Mon, May 11, 2020 at 09:13:42AM +0200, Peter Krempa wrote: > On Fri, May 08, 2020 at 19:02:21 -0400, Chris Jester-Young wrote: > > It would be great if you could describe that 'pvscsi' indeed is the > vmware paravirtual scsi controller even in qemu, because I had to dig > through the code to figure it out. > > > Signed-off-by: Chris Jester-Young <cky@xxxxxx> > > --- > > src/qemu/qemu_capabilities.c | 2 ++ > > src/qemu/qemu_capabilities.h | 1 + > > src/qemu/qemu_command.c | 4 +++- > > src/qemu/qemu_validate.c | 9 ++++++++- > > tests/qemucapabilitiesdata/caps_1.5.3.x86_64.xml | 1 + > > Can the 'pvscsi' device be compiled out using any upstream way? If not > we don't really need a capability for it since qemu-1.5.3 is the oldest > supported qemu and all other versions support it as well. Every device that isn't hardwired a machine board in QEMU can be compiled out, using the KConfig framework. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|