Re: [libvirt-ci PATCH 04/12] lcitool: Use a temporary JSON file to pass extra variables

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2020-05-06 at 14:05 +0200, Erik Skultety wrote:
>          ansible_cfg_path = os.path.join(base, "ansible.cfg")
>          playbook_base = os.path.join(base, "playbooks", playbook)
>          playbook_path = os.path.join(playbook_base, "main.yml")
> -
> -        extra_vars = json.dumps({
> +        extra_vars_path = os.path.join(tempdir.name, "extra_vars.json")
> +        extra_vars = {

Leave the empty line between all the various paths and extra_vars.

With that changed,

  Reviewed-by: Andrea Bolognani <abologna@xxxxxxxxxx>

-- 
Andrea Bolognani / Red Hat / Virtualization




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux