On Thu, May 07, 2020 at 12:54:26PM +0200, Andrea Bolognani wrote: > On Thu, 2020-05-07 at 11:41 +0100, Daniel P. Berrangé wrote: > > On Thu, May 07, 2020 at 12:04:10PM +0200, Andrea Bolognani wrote: > > > Partially related point: I just realized that, among the projects > > > we've added to GitLab CI so far, I don't think there's a single one > > > where we're testing that we can successfully build RPMs. This is > > > something that CentOS CI does, and I think it's important that we > > > keep testing it on GitLab CI. > > > > The way we tested RPM builds was a bit gross in CentOS as we were > > hacking the spec to cut out the BuildRequires. I'd like to figure > > out a better way todo that which actually reflects the way we'll > > run builds for real. > > > > When testing against distro-provided libvirtd this is quite easy > > as we have the right devel packages present. > > > > Testing against GIT it is harder. > > I realize that, but while we figure out a better way can we keep > the current way around? Otherwise we're losing test coverage for > something that people probably don'normally run as part of their > everyday development workflow. I took the lazy route and just used --nodeps Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
