Re: [perl PATCH v4 3/3] gitlab: add CONTRIBUTING.rst file to indicate use of merge requests

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 2020-05-05 at 12:40 +0100, Daniel P. Berrangé wrote:
> +++ b/CONTRIBUTING.rst
> @@ -0,0 +1,28 @@
> +============================
> +Contributing to libvirt-perl
> +============================
> +
> +The libvirt Perl API binding accepts code contributions via merge requests
> +on the GitLab project:

s/binding accepts/bindings accept/

This retroactively applies to all other patches where I forgot to
notice the verb has to be changed as well.

> +CI pipline results for merge requests will be visible via the contributors'
> +own private repository fork:
> +
> +   https://gitlab.com/::YOUR-USER-NAME::/libvirt-perl/pipelines

s/::YOUR-USER-NAME::/yourusername/

> +Contributions submitted to the project must be in compliance with the
> +Developer Certificate of Origin Version 1.1. This is documented at:
> +
> +   https://developercertificate.org/

Links should not be indented.

> +In indicate compliance, each commit in a series must have a "Signed-off-by"
> +tag with the submittor's name and email address. This can be added by passing
> +the ``-s`` flag to ``git commit`` when creating the patches.

s/submittor/submitter/


With the above fixed,

  Reviewed-by: Andrea Bolognani <abologna@xxxxxxxxxx>

-- 
Andrea Bolognani / Red Hat / Virtualization





[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux