> > diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c > > index 024b2ba..1fbb86a 100644 > > --- a/src/qemu/qemu_conf.c > > +++ b/src/qemu/qemu_conf.c > [...] > > @@ -4714,11 +4771,84 @@ syntax: > > no_memory: > > virReportOOMError(conn); > > error: > > - virCPUDefFree(cpu); > > return -1; > > } > > > > > > +static int > > +qemuParseCommandLineSmp(virConnectPtr conn, > > + virDomainDefPtr dom, > > + const char *val) > > +{ > > + unsigned int sockets = 0; > > + unsigned int cores = 0; > > + unsigned int threads = 0; > > + int i; > > + int nkws; > > + char **kws; > > + char **vals; > > + int n; > > + char *end; > > + int ret; > > + > > + nkws = qemuParseCommandLineKeywords(conn, val, &kws, &vals, 1); > > What's the purpose of the 1 here? qemuParseCommandLineKeywords takes 4 > parameters, you pass 5. This breaks compilation for me. Ah, I should have mentioned it explicitly... this patch requires 'Enhance qemuParseCommandLineKeywords' patch which I submitted earlier and which was already acked but haven't been pushed yet. Jirka -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list