On Wed, 2020-05-06 at 15:55 +0200, Michal Privoznik wrote: > On 5/6/20 2:54 PM, Andrea Bolognani wrote: > > +++ b/tests/virhostdevmock.c > > @@ -0,0 +1,29 @@ > > +/* > > + * Copyright (C) 2020 Red Hat, Inc. > > + * SPDX-License-Identifier: LGPL-2.1-or-later > > + */ > > + > > +#include <config.h> > > + > > +#include "virutil.h" > > +#include "virmock.h" > > + > > +static char *(*real_virGetUserRuntimeDirectory)(void); > > This is not needed, you are not calling the original function anywhere. > Moreover, the original function must be marked as attribute no-inline. Good point! I've squashed your changes in and pushed. Thanks :) -- Andrea Bolognani / Red Hat / Virtualization
