Re: [libvirt-dbus PATCH] meson: Exclude some files from releases

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2020-05-06 at 11:29 +0100, Daniel P. Berrangé wrote:
> On Wed, May 06, 2020 at 12:16:24PM +0200, Andrea Bolognani wrote:
> > Both .mailmap and .travis.yml only make sense in the context of a
> > git checkout, so we should not include them in releases.
> 
> Does it really matter if we include them though ? AFAIK they don't cause
> any harm, and it feels like we're just creating extra work for ourselves
> by deciding to exclude them.  The same can be said of the .gitlab-ci.yml
> file, and supporting things we'll be introducing like the dockerfiles.
> 
> One of the things I like about meson is that we can essentially stop
> worrying about what goes into the dist tarball, and simply let it have
> the entire of git contents (aside from the couple of generated files
> we added). So my gut feeling says to not bother trying to exclude files.

It's certainly not a deal breaker to have a couple extra files in the
release archives, but I think it's much tidier not to have them
there. It's really not that much extra work anyway... But, if you and
Pavel share the opinion that we shouldn't bother, I will not try to
push this further :)

-- 
Andrea Bolognani / Red Hat / Virtualization





[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux