Re: [libvirt-python PATCH v3 2/3] gitlab: introduce CI jobs testing git master & distro libvirt

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, May 01, 2020 at 05:56:23PM +0200, Pavel Hrdina wrote:
> On Fri, May 01, 2020 at 10:20:03AM +0100, Daniel P. Berrangé wrote:
> > The python build needs to validate two axis
> > 
> >  - A variety of libvirt versions
> >  - A variety of python versions
> > 
> > We get coverage for both these axis by running a build against the
> > distro provided libvirt packages. All that is then missing is a build
> > against the latest libvirt git master, which only needs to be run on
> > a single distro, for which CentOS 8 is picked as a stable long life
> > base.
> > 
> > Signed-off-by: Daniel P. Berrangé <berrange@xxxxxxxxxx>
> > ---
> >  .gitlab-ci.yml                       | 185 +++++++++++++++++++++++++++
> >  ci/README.rst                        |  13 ++
> >  ci/libvirt-centos-7.Dockerfile       |  86 +++++++++++++
> >  ci/libvirt-centos-8.Dockerfile       |  64 +++++++++
> >  ci/libvirt-debian-10.Dockerfile      |  56 ++++++++
> >  ci/libvirt-debian-9.Dockerfile       |  59 +++++++++
> >  ci/libvirt-debian-sid.Dockerfile     |  56 ++++++++
> >  ci/libvirt-fedora-31.Dockerfile      |  53 ++++++++
> >  ci/libvirt-fedora-32.Dockerfile      |  53 ++++++++
> >  ci/libvirt-fedora-rawhide.Dockerfile |  54 ++++++++
> >  ci/libvirt-opensuse-151.Dockerfile   |  55 ++++++++
> >  ci/libvirt-ubuntu-1804.Dockerfile    |  59 +++++++++
> >  ci/libvirt-ubuntu-2004.Dockerfile    |  56 ++++++++
> >  ci/refresh                           |  27 ++++
> >  14 files changed, 876 insertions(+)
> >  create mode 100644 .gitlab-ci.yml
> >  create mode 100644 ci/README.rst
> >  create mode 100644 ci/libvirt-centos-7.Dockerfile
> >  create mode 100644 ci/libvirt-centos-8.Dockerfile
> >  create mode 100644 ci/libvirt-debian-10.Dockerfile
> >  create mode 100644 ci/libvirt-debian-9.Dockerfile
> >  create mode 100644 ci/libvirt-debian-sid.Dockerfile
> >  create mode 100644 ci/libvirt-fedora-31.Dockerfile
> >  create mode 100644 ci/libvirt-fedora-32.Dockerfile
> >  create mode 100644 ci/libvirt-fedora-rawhide.Dockerfile
> >  create mode 100644 ci/libvirt-opensuse-151.Dockerfile
> >  create mode 100644 ci/libvirt-ubuntu-1804.Dockerfile
> >  create mode 100644 ci/libvirt-ubuntu-2004.Dockerfile
> >  create mode 100755 ci/refresh
> > 
> > diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
> > new file mode 100644
> > index 0000000..bc95d41
> > --- /dev/null
> > +++ b/.gitlab-ci.yml
> > @@ -0,0 +1,185 @@
> > +
> > +stages:
> > +  - prebuild
> > +  - containers
> > +  - builds
> > +  - docs
> > +
> > +.container_job_template: &container_job_definition
> > +  image: docker:stable
> > +  stage: containers
> > +  services:
> > +    - docker:dind
> > +  before_script:
> > +    - export TAG="$CI_REGISTRY_IMAGE/ci-$NAME:latest"
> > +    - export COMMON_TAG="$CI_REGISTRY/libvirt/libvirt-perl/ci-$NAME:latest"
> 
> This doesn't look right, shouldn't we use libvirt-python here?

Err, yes, of course. This would have meant the cache never matched as
the dockerfile is different. I'll push the obvious fix.


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|





[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux