Re: [libvirt-ci PATCH] vars: Add python3-wheel to the base package dependencies

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2020-04-29 at 11:21 +0200, Erik Skultety wrote:
> On platforms where we need to install meson from pip, one will very
> likely see something similar to this when building a container from the
> generated Dockerfile:
> 
>     Collecting meson==0.49.0
>       Downloading <url>/meson-0.49.0.tar.gz (1.3MB)
>         100% |################################| 1.3MB 874kB/s
>     Building wheels for collected packages: meson
>       Running setup.py bdist_wheel for meson ... error
>       error: invalid command 'bdist_wheel'
>       ----------------------------------------
>       Failed building wheel for meson
>       Running setup.py clean for meson
>     Failed to build meson
> 
> Pip is missing the 'wheel' package necessary to build a wheel from
> sources, if it fails to do that, it falls back to the good old:
>     $ setup.py install meson
> which succeeds and no harm was done. However, seeing an error in the
> log always raises eyebrows, so let's fix that very simply by installing
> the 'wheel' package which is available on all supported platforms.
> 
> Signed-off-by: Erik Skultety <eskultet@xxxxxxxxxx>
> ---
> Alternatively, we could use --no-cache-dir with pip install, but I'm not sure
> whether it would be enough with new versions of pip. I still feel like
> installing the 'wheel' package explicitly is a more transparent and safe fix
> even though we don't benefit from the resulting meson wheel package inside
> containers at all.
> 
>  guests/vars/mappings.yml      | 4 ++++
>  guests/vars/projects/base.yml | 1 +
>  2 files changed, 5 insertions(+)

Reviewed-by: Andrea Bolognani <abologna@xxxxxxxxxx>

-- 
Andrea Bolognani / Red Hat / Virtualization




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux