Re: [libvirt-ci PATCH 11/13] config: Move the virt-install settings from install.yml to the config

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2020-04-22 at 15:28 +0200, Erik Skultety wrote:
> +++ b/guests/lcitool
> @@ -175,6 +175,33 @@ class Config:
>          flavor = cfg.get("install").get("flavor", "test")
>          cfg["install"]["flavor"] = flavor
>  
> +        virt_type = cfg.get("install").get("virt_type", "kvm")
> +        cfg["install"]["virt_type"] = virt_type
> +
> +        arch = cfg.get("install").get("arch", "x86_64")
> +        cfg["install"]["arch"] = arch
> +
> +        machine = cfg.get("install").get("machine", "pc")
> +        cfg["install"]["machine"] = machine
> +
> +        cpu_model = cfg.get("install").get("cpu_model", "host-passthrough")
> +        cfg["install"]["cpu_model"] = cpu_model
> +
> +        vcpus = cfg.get("install").get("vcpus", 2)
> +        cfg["install"]["vcpus"] = vcpus
> +
> +        memory_size = cfg.get("install").get("memory_size", 2)
> +        cfg["install"]["memory_size"] = memory_size
> +
> +        disk_size = cfg.get("install").get("disk_size", 15)
> +        cfg["install"]["disk_size"] = disk_size
> +
> +        storage_pool = cfg.get("install").get("storage_pool", "default")
> +        cfg["install"]["storage_pool"] = storage_pool
> +
> +        network = cfg.get("install").get("network", "default")
> +        cfg["install"]["network"] = network

All this code will go away once you start obtaining default from the
in-repo config.toml.

For the remaining changes,

  Reviewed-by: Andrea Bolognani <abologna@xxxxxxxxxx>

-- 
Andrea Bolognani / Red Hat / Virtualization




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux