On Tue, Apr 28, 2020 at 09:39:31AM +0200, Andrea Bolognani wrote: > On Wed, 2020-04-22 at 15:28 +0200, Erik Skultety wrote: > > +[gitlab] > > +# GitLab runner agent registration options, applies only if flavor == 'gitlab'. > > + > > +# GitLab server URL to register the runner. > > +#gitlab_url = "https://gitlab.com"; > > + > > +# GitLab runner registration token. (mandatory) > > +#gitlab_runner_secret = "" > > Additional nit: since TOML is organized in sections, it doesn't make > sense to include the section name in the key name, so this should > look like > > [gitlab] > url = "https://gitlab.com"; > runner_secret = "..." Absolutely agreed. That was the initial approach, however it didn't pair with the naming used within the Ansible playbooks, so I changed it. If I'm not mistaken "url" will cause a collision with another variable, that's why I was explicit with naming in the config, although I agree that from the config POV it doesn't make sense to include the section prefix. -- Erik Skultety
