On Mon, Apr 27, 2020 at 12:54:21PM +0200, Andrea Bolognani wrote: > Debian always runs autoreconf at package build time, which means > that apt-get build-dep will bring in everything that's needed to > build libvirt from a git clone; Fedora and RHEL, however, skip > this step, so we have to install some extra packages manually. > > Signed-off-by: Andrea Bolognani <abologna@xxxxxxxxxx> > --- > CONTRIBUTING.rst | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/CONTRIBUTING.rst b/CONTRIBUTING.rst > index 12b6e3f0e8..32829b1d96 100644 > --- a/CONTRIBUTING.rst > +++ b/CONTRIBUTING.rst > @@ -33,6 +33,15 @@ if you're on a RHEL-based distribution or > > if you're on a Debian-based one. > > +Note that, for the RHEL-based case, if you're on a machine where you > +haven't done any C development before, you will probably also need > +to run > + > +:: > + > + $ sudo dnf groupinstall "C Development Tools and Libraries" This group doesn't exist on any RHEL distro, and dnf itself only exists in RHEL >= 8. I htink we should be just listing the packages we need explicitly rather than relying on a group whose name & contents change over time. > + $ sudo dnf install rpm-build > + > You might still be missing some dependencies if your distribution is > shipping an old libvirt version, but that will get you much closer to > where you need to be to build successfully from source. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
