Re: [PATCH 3/3] Add version info on domaincaps doc

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Apr 15, 2020 at 11:34:06 +0000, Sebastian Mitterle wrote:
> 1. Add 'since 5.10' as commonly used in formatdomain to avoid
>    misunderstandings if element is not present (Is it not supported
>    because of my version or because of my environment?)
> 
> Signed-off-by: Sebastian Mitterle <smitterl@xxxxxxxxxx>
> ---
>  docs/formatdomaincaps.html.in | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

For some reason we didn't include the since tags here, but it certainly
might come in handy.


> 
> diff --git a/docs/formatdomaincaps.html.in b/docs/formatdomaincaps.html.in
> index 4056e0bd31..70b1d2a8f9 100644
> --- a/docs/formatdomaincaps.html.in
> +++ b/docs/formatdomaincaps.html.in
> @@ -561,7 +561,8 @@
>  
>      <p>Reports whether the hypervisor will obey the &lt;backingStore&gt;
>      elements configured for a &lt;disk&gt; when booting the guest, hotplugging
> -    the disk to a running guest, or similar.
> +    the disk to a running guest, or similar, <span class="since">since 5.10
> +    </span>.

I'll just put the contents of the since tag into brackets after the end
of the sentence.

>      </p>
>  
>      <h4><a id="featureBackup">backup</a></h4>

Reviewed-by: Peter Krempa <pkrempa@xxxxxxxxxx>

> -- 
> 2.25.2
> 





[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux