On Wed, 2020-04-22 at 10:43 -0600, Jim Fehlig wrote: > On 4/22/20 9:10 AM, Andrea Bolognani wrote: > > If you look at most (all?) other entries, they look like > > > > subsystem: Change > > > > which is the same style we use for commit messages. > > If you really want to split hairs, the subsytem is 'libxl'. But I don't think > that is good for news since in general folks know of the 'Xen' project, but not > 'libxl'. However, now that the old xen driver is removed libxl could be renamed > to xen :-). Yeah, I know of the history :) And I agree that we should probably rename the driver to xen[1]; as you probably remember, the standalone daemon is called virtxend and not virtlibxld already :) > > Xen seems to be the outlier when it comes to following this style, > > both in release notes and to some extent in commit messages. It would > > be great if it could fall in line with the rest of the code base. > > Sorry for being out of line. I'll try to be more conscious of that in the future. Nothing to apologize for! I just pointed it out so that we can, in time, get closer to a state of consistency :) [1] Although it will never be a full rename, because it still need to handle libxl:// connection URLs. -- Andrea Bolognani / Red Hat / Virtualization