On Tue, Apr 21, 2020 at 4:03 PM Daniel P. Berrangé <berrange@xxxxxxxxxx> wrote: > > On Tue, Apr 21, 2020 at 03:48:41PM +0200, Rafael Fonseca wrote: > > This patch series convert various simple instances of virObject to a > > GObject equivalent. > > > > virLockableObject and virObjects which are subclassed will be covered > > in future patchsets. > > > > New in v2: > > - use *Dispose for unreffing objects and *Finalize for freeing data, > > as suggested in the GLib documentation > > Can you point to the docs with the rationale for that. Looking at the > patches the distinction looks pretty arbitary, creating extra methods > without an obvious benefit. https://developer.gnome.org/gobject/stable/gobject-memory.html#gobject-memory-cycles I did the changes as requested here: https://www.redhat.com/archives/libvir-list/2020-April/msg00383.html Att -- Rafael Fonseca
