Re: [PATCH 2/2] docs: Improve zPCI section in pci-addresses.rst

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2020-04-16 at 17:56 +0200, Boris Fiuczynski wrote:
>  Note that the PCI bridge is not visible in the guest; s390x always has a flat
> -topology.
> +topology. Also ``fid`` does not define slot or function of the PCI address.

This sentence is unnecessary, since you explain what fid does just
a few lines later.

>  will result in the exactly same view in the guest, as the addresses there
> -are generated from the information provided via the ``zpci`` element (in
> -fact, from the ``uid``).
> +are generated from the information provided via the ``zpci`` element:
> +the ``uid`` is used as PCI domain, and the ``fid`` is used as the PCI devices
> +slot in the sysfs.

I think we need to be a bit more verbose to make sure we don't
confuse the reader, or better yet avoid mentioning "PCI slot"
altogether because the terminology is ambiguous. Something like

  [...] are generated from the information provided via the ``zpci``
  element: more specifically, ``uid`` is used as the PCI domain.
  ``fid`` doesn't appear in the PCI address itself, but it will be
  used in sysfs (``/sys/bus/pci/slots/$fid/...``).

-- 
Andrea Bolognani / Red Hat / Virtualization




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux