On Thu, 2020-04-16 at 12:29 +0200, Boris Fiuczynski wrote: > I suggest to use the zpci addressing from the removed example because it > outlines more clearly the differences in the parameters. > Something like the example below: > > For s390x machines, PCI addresses are handled yet differently. No > topology information is relayed in the PCI addresses; instead, the fid > and uid elements of the zpci device convey information. In the simplest > case, the following XML snippet > > <controller type='pci' index='0' model='pci-root'/> > <controller type='pci' index='1' model='pci-bridge'> > <model name='pci-bridge'/> > <target chassisNr='1'/> > <address type='pci' domain='0x0000' bus='0x00' slot='0x01' > function='0x0'> > <zpci uid='0x0001' fid='0x00000000'/> > </address> > </controller> > <interface type='bridge'> > <mac address='02:ca:fe:fa:ce:04'/> > <source bridge='virbr0'/> > <model type='virtio'/> > <address type='pci' domain='0x0000' bus='0x01' slot='0x01' > function='0x0'> > <zpci uid='0x0007' fid='0x00000003'/> > </address> > </interface> > > will result in the following in a Linux guest: > > 0007:00:00.0 Ethernet controller: Red Hat, Inc. Virtio network device You're right, this example is more illustrative. Care to submit a patch changing it? -- Andrea Bolognani / Red Hat / Virtualization