Re: [PATCH 4/4] tests: check e820_host option handling

[Jim Fehlig <jfehlig@xxxxxxxx>]

On 4/13/20 2:10 PM, Marek Marczykowski-Górecki wrote:
> Signed-off-by: Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>
> ---
>   tests/xlconfigdata/test-paravirt-e820_host.cfg | 13 +++++++-
>   tests/xlconfigdata/test-paravirt-e820_host.xml | 37 +++++++++++++++++++-
>   tests/xlconfigtest.c                           |  1 +-
>   3 files changed, 51 insertions(+)
>   create mode 100644 tests/xlconfigdata/test-paravirt-e820_host.cfg
>   create mode 100644 tests/xlconfigdata/test-paravirt-e820_host.xml
>
> diff --git a/tests/xlconfigdata/test-paravirt-e820_host.cfg b/tests/xlconfigdata/test-paravirt-e820_host.cfg
> new file mode 100644
> index 0000000..b9e5a48
> --- /dev/null
> +++ b/tests/xlconfigdata/test-paravirt-e820_host.cfg
> @@ -0,0 +1,13 @@
> +name = "XenGuest1"
> +uuid = "45b60f51-88a9-47a8-a3b3-5e66d71b2283"
> +maxmem = 512
> +memory = 512
> +vcpus = 4
> +e820_host = 1
> +localtime = 0
> +on_poweroff = "preserve"
> +on_reboot = "restart"
> +on_crash = "preserve"
> +vif = [ "mac=5a:36:0e:be:00:09" ]
> +bootloader = "/usr/bin/pygrub"
> +disk = [ "format=qcow2,vdev=xvda,access=rw,backendtype=qdisk,target=/var/lib/xen/images/debian/disk.qcow2" ]
> diff --git a/tests/xlconfigdata/test-paravirt-e820_host.xml b/tests/xlconfigdata/test-paravirt-e820_host.xml
> new file mode 100644
> index 0000000..955a780
> --- /dev/null
> +++ b/tests/xlconfigdata/test-paravirt-e820_host.xml
> @@ -0,0 +1,37 @@
> +<domain type='xen'>
> +  <name>XenGuest1</name>
> +  <uuid>45b60f51-88a9-47a8-a3b3-5e66d71b2283</uuid>
> +  <memory unit='KiB'>524288</memory>
> +  <currentMemory unit='KiB'>524288</currentMemory>
> +  <vcpu placement='static'>4</vcpu>
> +  <bootloader>/usr/bin/pygrub</bootloader>
> +  <os>
> +    <type arch='x86_64' machine='xenpv'>linux</type>
> +  </os>
> +  <features>
> +    <xen>
> +      <e820_host state='on'/>
> +    </xen>
> +  </features>
> +  <clock offset='utc' adjustment='reset'/>
> +  <on_poweroff>preserve</on_poweroff>
> +  <on_reboot>restart</on_reboot>
> +  <on_crash>preserve</on_crash>
> +  <devices>
> +    <disk type='file' device='disk'>
> +      <driver name='qemu' type='qcow2'/>
> +      <source file='/var/lib/xen/images/debian/disk.qcow2'/>
> +      <target dev='xvda' bus='xen'/>
> +    </disk>
> +    <controller type='xenbus' index='0'/>
> +    <interface type='ethernet'>
> +      <mac address='5a:36:0e:be:00:09'/>
> +    </interface>
> +    <console type='pty'>
> +      <target type='xen' port='0'/>
> +    </console>
> +    <input type='mouse' bus='xen'/>
> +    <input type='keyboard' bus='xen'/>
> +    <memballoon model='xen'/>
> +  </devices>
> +</domain>
> diff --git a/tests/xlconfigtest.c b/tests/xlconfigtest.c
> index 8faef16..8ea2503 100644
> --- a/tests/xlconfigtest.c
> +++ b/tests/xlconfigtest.c
> @@ -300,6 +300,7 @@ mymain(void)
>       DO_TEST("vif-multi-ip");
>       DO_TEST("usb");
>       DO_TEST("usbctrl");
> +    DO_TEST("paravirt-e820_host");
>   
>       testXLFreeDriver(driver);
>   

Reviewed-by: Jim Fehlig <jfehlig@xxxxxxxx>

Regards,
Jim