On Fri, Jan 15, 2010 at 05:42:31PM +0100, Daniel Veillard wrote: > On Fri, Jan 08, 2010 at 05:23:16PM +0000, Daniel P. Berrange wrote: > > When starting a guest, give every device a unique alias. This will > > be used for the 'id' parameter in -device args in later patches. > > It can also be used to uniquely identify devices in the monitor > > > > For old QEMU without -device, assign disk names based on QEMU's > > historical naming scheme. > > > > * src/qemu/qemu_conf.c: Assign unique device aliases > > * src/qemu/qemu_driver.c: Remove obsolete qemudDiskDeviceName > > and use the device alias in eject & blockstats commands > > --- > > src/qemu/qemu_conf.c | 173 ++++++++++++++++++++++++++++++++++++++++++++++++ > > src/qemu/qemu_driver.c | 104 ++++++----------------------- > > 2 files changed, 195 insertions(+), 82 deletions(-) > > > > How would the user see the alias in practice ? They won't be > dumped in the XML if I understand correctly so how to they get exposed ? Yes, they'll appear in the XML dump. Here is a huge example: http://www.redhat.com/archives/libvir-list/2010-January/msg00186.html Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :| -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list