Re: [libvirt PATCH 6/6] docs: replace site name with link type in download table

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Apr 09, 2020 at 04:48:19PM +0200, Ján Tomko wrote:
> On a Thursday in 2020, Daniel P. Berrangé wrote:
> > Instead of repeating the sitename "gitlab" over and over for the git and
> > bug tracker links, use the words "git" and "bugs" to distinguish them.
> > This makes it easier to distinguish links when the table header has
> > scrolled off the screen.
> > 
> > Signed-off-by: Daniel P. Berrangé <berrange@xxxxxxxxxx>
> > ---
> > docs/downloads.html.in | 104 ++++++++++++++++++++---------------------
> > 1 file changed, 52 insertions(+), 52 deletions(-)
> > 
> > diff --git a/docs/downloads.html.in b/docs/downloads.html.in
> > index 2bbae3fcc7..45c0d2c6c5 100644
> > --- a/docs/downloads.html.in
> > +++ b/docs/downloads.html.in
> > @@ -31,10 +31,10 @@
> >             <a href="https://libvirt.org/sources/";>libvirt</a>
> >           </td>
> >           <td>
> > -            <a href="https://gitlab.com/libvirt/libvirt";>gitlab</a>
> > +            <a href="https://gitlab.com/libvirt/libvirt";>git</a>
> 
> Here I prefer "gitlab" - lets me know what to expect upon clicking that.

Ok.

> 
> >           </td>
> >           <td>
> > -            <a href="https://gitlab.com/libvirt/libvirt/-/issues";>gitlab</a>
> > +            <a href="https://gitlab.com/libvirt/libvirt/-/issues";>bugs</a>
> 
> Similarly "issues" here.

I'll just make this change in the previous patch then, and discard
this one.

> 
> >           </td>
> >           <td class="gitmirror">
> >             <a href="https://libvirt.org/git/?p=libvirt.git;a=summary";>libvirt</a>
> 
> Either way:
> Reviewed-by: Ján Tomko <jtomko@xxxxxxxxxx>
> 
> Jano



Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|





[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux