Re: [PATCH ocaml] build: skip github lockdown file in manifest check

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tuesday, 7 April 2020 20:14:44 CEST Daniel P. Berrangé wrote:
> The github lockdown file is not intended to be included in any built
> dist, so should be excluded when checking the manifest.
> 
> Signed-off-by: Daniel P. Berrangé <berrange@xxxxxxxxxx>
> ---
> 
> Pushed as a CI build fix
> 
>  Makefile.in | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Makefile.in b/Makefile.in
> index 4357ba6..54ecaf3 100644
> --- a/Makefile.in
> +++ b/Makefile.in
> @@ -86,7 +86,7 @@ dist: ChangeLog
>  	ls -l $(PACKAGE)-$(VERSION).tar.gz
>  
>  check-manifest:
> -	git ls-files > .check-manifest; \
> +	git ls-files | grep -v .github/lockdown.yml > .check-manifest; \

Thanks, this seems OK.

Maybe one small improvement if you have the time/will: skip the entire
.github/ toplevel directory, so in case we add more files there it will
not require any change.

Thanks,
-- 
Pino Toscano

Attachment: signature.asc
Description: This is a digitally signed message part.


[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux