On Tue, 2020-04-07 at 18:18 +0100, Daniel P. Berrangé wrote: > On Tue, Apr 07, 2020 at 04:04:16PM +0200, Andrea Bolognani wrote: > > On Tue, 2020-03-31 at 11:08 +0100, Daniel P. Berrangé wrote: > > > + script: > > > + - python2 planet.py virt-tools/config.ini > > > > Python 2, EWWWWW! > > Yep, this is why I picked centos:7 image, as it contains py2 by > default. I had figured as much :) > > IIUC Planet itself is abandonware now, and has been for a fairly long > > time. Can we investigate an alternative? > > We could, but it is a matter of time & priorities. > > This site just looks after itself without issues on the software > side really, so while python 2 is yuk, it isn't really a real > world problem for us that needs addressing any time soon. I was not suggesting that it needs to happen before this series can be merged, or even in the near future! But it should be something that we keep in mind and eventually address. > > > + <li><a href="https://gitlab.com/libvirt/virttools-planet/-/blob/master/README.md";>Add your blog!</a></li> > > > > I think we can just point people to the repository. > > Linking to the README was intentional as it means the instructions are > immediately visible to the user, instead of hidden off the bottom of > the browser screen after the repo file listing. I think the latter might feel more natural these days, but okay. > > > + &emdash; > > > + <a href="https://gitlab.com/libvirt/virttools-planet/-/blob/master/virt-tools/basic/index.html.tmpl"; title="Edit this page">Edit this page</a> > > > > This seems unnecessary. If anything, we might consider replacing the > > original OpenShift Online "powered by" with GitLab Pages. > > The goal is that all the webpages we publish have an "edit page" link > that goes to the most appropriate source content for the page. It is > intended to encourage contribution by showing people where/what to try > editting instead of leaving them to try to find it themselves. Sounds like a worthy goal. Just s/emdash/mdash/ before pushing. -- Andrea Bolognani / Red Hat / Virtualization
