On Tue, Apr 07, 2020 at 08:39:10 +0200, Ján Tomko wrote:
> On a Friday in 2020, Jiri Denemark wrote:
> >The hint was introduced a long time ago when broken TSX implementation
> >was found in Haswell and Broadwell CPUs. Since then many more CPUs with
> >TSX were introduced and and disabled due to TAA vulnerability.
> >
> >Thus the hint is not very useful and I think removing it is a better
> >choice then updating it to cover all current noTSX models.
> >
>
> This partially reverts:
> commit 7f127ded657b24e0e55cd5f3539ef5b2dc935908
> cpu: Rework cpuCompare* APIs
>
>
> >Signed-off-by: Jiri Denemark <jdenemar@xxxxxxxxxx>
> >---
> > src/cpu/cpu_x86.c | 42 ++++++------------------------------------
> > 1 file changed, 6 insertions(+), 36 deletions(-)
> >
> >diff --git a/src/cpu/cpu_x86.c b/src/cpu/cpu_x86.c
> >index ce15bb0454..eeb16c2763 100644
> >--- a/src/cpu/cpu_x86.c
> >+++ b/src/cpu/cpu_x86.c
> >@@ -1937,7 +1937,6 @@ virCPUx86Compare(virCPUDefPtr host,
> > bool failIncompatible)
> > {
> > virCPUCompareResult ret = VIR_CPU_COMPARE_ERROR;
> >- virCPUx86MapPtr map;
> > virCPUx86ModelPtr model = NULL;
>
> model is unused after this patch (that will cause a build error with
> clang after the g_auto conversion later in the series)
Oh, I missed this. Fixed, thanks.
Jirka
