On 29. 3. 2020 12:44, Prathamesh Chavan wrote: > Redeclared variables in script functions marked as local. > Variables `guest_running` and `guests_shutting_down` in the > functions 'guest_is_on` and `check_guests_shutdown` were > untouched, as the functions returned values in these > variables. > > Signed-off-by: Prathamesh Chavan <pc44800@xxxxxxxxx> > --- > New changes: All the local variable declarations brought together > at the beginning of the function. > > Travis-CI Build report: https://travis-ci.org/github/pratham-pc/libvirt/builds/668315184 > Previous version: https://www.redhat.com/archives/libvir-list/2020-March/msg01297.html > > tools/libvirt-guests.sh.in | 125 +++++++++++++++++++++---------------- > 1 file changed, 72 insertions(+), 53 deletions(-) Reviewed-by: Michal Privoznik <mprivozn@xxxxxxxxxx> and pushed. Congratulations on your first libvirt contribution! Michal
