Re: [PATCH 01/15] qemu: introducing qemu_validate.c/h

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 4/3/20 10:21 AM, Ján Tomko wrote:
Moving the first functions seems more important than the fact that
we are introducing a new file.

qemu: move qemuDomainDefValidateFeatures to qemu_validate

On a Thursday in 2020, Daniel Henrique Barboza wrote:
While moving validations from qemu_command to qemu_domain,
it was suggested that we should instead move them to a new
file [1] because qemu_domain is already too crowded.


This will become a part of the git history, but the cover letter will
not, so the above [1] will become a dead reference.

I'd just drop the above paragraph.

This patch introduces a new file to host such validations from

s/such/domain/

the QEMU driver. And to get things started, let's move
qemuDomainDefValidateFeatures() to this new file.

Signed-off-by: Daniel Henrique Barboza <danielhb413@xxxxxxxxx>
---
po/POTFILES.in           |   1 +
src/qemu/Makefile.inc.am |   2 +
src/qemu/qemu_domain.c   | 286 +-----------------------------------
src/qemu/qemu_validate.c | 310 +++++++++++++++++++++++++++++++++++++++
src/qemu/qemu_validate.h |  29 ++++
5 files changed, 344 insertions(+), 284 deletions(-)
create mode 100644 src/qemu/qemu_validate.c
create mode 100644 src/qemu/qemu_validate.h


Reviewed-by: Ján Tomko <jtomko@xxxxxxxxxx>
(no need to resend unless you disagree, I'll try to merge as much as I
can today so that new patches can use the file)


I'm fine with your changes and suggestions. Go for it.



Thanks,


DHB


Jano






[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux