On Tue, Mar 31, 2020 at 05:43:37PM +0200, Andrea Bolognani wrote:
> On Thu, 2020-03-26 at 14:33 +0100, Erik Skultety wrote:
> > +++ b/guests/lcitool
> > + def get_gitlab_runner_token_file(self):
> > + gitlab_runner_token_file = self._get_config_file("gitlab-runner-token")
> > +
> > + try:
> > + with open(gitlab_runner_token_file, "r") as infile:
> > + if not infile.readline().strip():
> > + raise ValueError
> > + except Exception as ex:
> > + raise Exception(
> > + "Missing or invalid gitlab runner token file ({}): {}".format(
> > + gitlab_runner_token_file, ex
> > + )
> > + )
> > +
> > + return gitlab_runner_token_file
>
> As per my comments to patch 3/5, we want the token to be stored in
> the vault instead that on the disk, which will make most of this
> commit not necessary.
I already responded to this one, TL;DR I don't think we want to tie it to
libvirt's git only, what if someone has their own testing gitlab instance
deployed and they want to deploy the machine there first and only then submit
the runner to libvirt gitlab CI?
--
Erik Skultety
