Re: [PATCH] rng: Support encryption and slices element in snapshot XML

[Daniel Henrique Barboza <danielhb413@xxxxxxxxx>]

On 4/1/20 11:10 AM, Han Han wrote:
> Signed-off-by: Han Han <hhan@xxxxxxxxxx>
> ---


Looks good. I'd just rename the commit to "domainsnapshot.rng: Support encryption
and slices element" because prefixing the commit with "rng" can be misleading
with commits related to the "rng" virtio backend.




DHB



>   docs/schemas/domainsnapshot.rng | 12 ++++++++++++
>   1 file changed, 12 insertions(+)
>
> diff --git a/docs/schemas/domainsnapshot.rng b/docs/schemas/domainsnapshot.rng
> index 8e39feb2..c881da74 100644
> --- a/docs/schemas/domainsnapshot.rng
> +++ b/docs/schemas/domainsnapshot.rng
> @@ -160,6 +160,12 @@
>                       <zeroOrMore>
>                         <ref name='devSeclabel'/>
>                       </zeroOrMore>
> +                    <optional>
> +                      <ref name='diskSourceCommon'/>
> +                    </optional>
> +                    <optional>
> +                      <ref name="encryption"/>
> +                    </optional>
>                       <empty/>
>                     </element>
>                   </optional>
> @@ -179,6 +185,12 @@
>                       <zeroOrMore>
>                         <ref name='devSeclabel'/>
>                       </zeroOrMore>
> +                    <optional>
> +                      <ref name='diskSourceCommon'/>
> +                    </optional>
> +                    <optional>
> +                      <ref name="encryption"/>
> +                    </optional>
>                       <empty/>
>                     </element>
>                   </optional>