Re: [PATCH v2 4/4] qemu: add support for 'multidevs' option

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Montag, 30. März 2020 16:45:08 CEST Ján Tomko wrote:
> >> A change to qemuxml2argvtest is needed.
> >> 
> >> If you already added the XML file to qemuxml2argvdata in the previous
> >> commit, all you need to to to generate the output file is:
> >> * add a new DO_TEST_CAPS_LATEST line to qemuxml2argvtest.c
> >
> >Looking at the existing test cases, it probably makes sense to extend
> >qemuxml2argvdata/virtio-options.xml instead of adding a separate XML file,
> 
> >that is:
> That one is aiming at testing the iommu and ats options common for
> virtio devices.
> 
> The 'fs9p' test would be a better candidate for adding these,
> but I'd still rather add a new file - to show that the command line
> for the old config remains unchanged.

Convinced. I change it.

Best regards,
Christian Schoenebeck







[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux