Re: [PATCH v2 2/4] conf: Add support for http(s) query strings

[Peter Krempa <pkrempa@xxxxxxxxxx>]

On Mon, Mar 30, 2020 at 16:18:26 +0200, Ján Tomko wrote:
> On a Monday in 2020, Peter Krempa wrote:
> > Add a new attribute for holding the query part for http(s) disks.
> > 
> > Signed-off-by: Peter Krempa <pkrempa@xxxxxxxxxx>
> > ---
> > docs/formatdomain.html.in                                  | 7 ++++++-
> > docs/schemas/domaincommon.rng                              | 6 ++++++
> > src/conf/domain_conf.c                                     | 5 +++++
> > src/util/virstoragefile.c                                  | 1 +
> > src/util/virstoragefile.h                                  | 1 +
> > tests/qemuxml2argvdata/disk-network-http.xml               | 2 +-
> > .../qemuxml2xmloutdata/disk-network-http.x86_64-latest.xml | 2 +-
> > 7 files changed, 21 insertions(+), 3 deletions(-)
> > 
> > diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in
> > index 6dbf449698..aaeb05961f 100644
> > --- a/docs/formatdomain.html.in
> > +++ b/docs/formatdomain.html.in
> > @@ -2847,7 +2847,7 @@
> >   &lt;/disk&gt;
> >   &lt;disk type='network' device='cdrom'&gt;
> >     &lt;driver name='qemu' type='raw'/&gt;
> > -    &lt;source protocol="http" name="url_path"&gt;
> > +    &lt;source protocol="http" name="url_path" query="foo=bar&amp;amp;baz=flurb&gt;
> >       &lt;host name="hostname" port="80"/&gt;
> >       &lt;cookies&gt;
> >         &lt;cookie name="test"&gt;somevalue&lt;/cookie&gt;
> > @@ -3113,6 +3113,11 @@
> >               ('tls' <span class="since">Since 4.5.0</span>)
> >               </p>
> > 
> > +              <p>For protocols <code>http</code> and <code>https</code> an
> > +              optional attribute <code>query</code> specifies the query string.
> > +              (<span class="since">Since 6.2.0</span>)
> 
> Should this be 6.3.0? Or are we calling this a bugfix?

This is breaking certain versions of virt-v2v which didn't switch to
nbdkit yet so I'm willing to call this a bugfix.