Hi On Mon, Mar 30, 2020 at 1:54 PM Daniel P. Berrangé <berrange@xxxxxxxxxx> wrote: > > On Sat, Mar 28, 2020 at 12:38:57AM +0100, marcandre.lureau@xxxxxxxxxx wrote: > > From: Marc-André Lureau <marcandre.lureau@xxxxxxxxxx> > > > > Add an option to ease setting up a VM with existing libvirt qemu.conf. > > > > Fixes: > > https://bugzilla.redhat.com/show_bug.cgi?id=1817776 > > > > Signed-off-by: Marc-André Lureau <marcandre.lureau@xxxxxxxxxx> > > --- > > docs/manpages/virt-qemu-run.rst | 6 ++++++ > > src/libvirt_private.syms | 1 - > > src/qemu/qemu_shim.c | 36 +++++++++++++++++++++++++++++++++ > > 3 files changed, 42 insertions(+), 1 deletion(-) > > > > diff --git a/docs/manpages/virt-qemu-run.rst b/docs/manpages/virt-qemu-run.rst > > index b06c311b1d..3196b4c8f4 100644 > > --- a/docs/manpages/virt-qemu-run.rst > > +++ b/docs/manpages/virt-qemu-run.rst > > @@ -71,6 +71,12 @@ is a path to the XML description of the secret, whose UUID should > > match a secret referenced in the guest domain XML. The ``VALUE-FILE`` > > is a path containing the raw value of the secret. > > > > +``-c``, ``--with-config`` > > + > > +Copy the libvirt qemu.conf configuration to the root directory. If > > +there is already a qemu.conf file in the $ROOT/etc directory, exit > > +with failure. > > As discussed in the bugzilla, we really don't want to be using the > global qemu.conf file in combination with the embedded driver. We > are not intending to guarantee that the embedded driver will share > the same defaults as the global drivers. > > In general we want to eliminate the need to touch qemu.conf at all. With qemu:///embed, is the $root/etc/qemu.conf supposed to be user configurable? If not, then it should not even be accessed. Otherwise, having an option to ease setting it up would be welcome! If not from the user/system libvirt config, from a given path (for me, it will likely always be my user libvirt config anyway)
