Re: [PATCH v2 03/11] conf: Move virDomainGenerateMachineName to hypervisor/

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Mar 26, 2020 at 04:15:07PM +0100, Michal Privoznik wrote:
> The virDomainGenerateMachineName() function doesn't belong in
> src/conf/ really, because it has nothing to do with domain XML
> parsing. It landed there because of lack of better place in the
> past. But now that we have src/hypervisor/ the function should
> live there. At the same time, the function name is changed to
> match new location.
> 
> Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx>
> Reviewed-by: Andrea Bolognani <abologna@xxxxxxxxxx>
> Reviewed-by: Daniel Henrique Barboza <danielhb413@xxxxxxxxx>
> ---
>  src/conf/domain_conf.c         | 72 ---------------------------------
>  src/conf/domain_conf.h         |  7 ----
>  src/hypervisor/domain_driver.c | 74 ++++++++++++++++++++++++++++++++++
>  src/hypervisor/domain_driver.h |  7 ++++
>  src/libvirt_private.syms       |  2 +-
>  src/lxc/lxc_domain.c           |  3 +-
>  src/qemu/qemu_domain.c         |  7 ++--
>  tests/virsystemdtest.c         |  5 ++-
>  8 files changed, 91 insertions(+), 86 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange@xxxxxxxxxx>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|





[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux