Re: [PATCH] qemuCheckpointCreateXML: Check VM liveness first

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Mar 26, 2020 at 12:13:52 -0500, Eric Blake wrote:
> On 3/26/20 12:08 PM, Peter Krempa wrote:
> > Move the liveness check prior to the capability check. If the VM is
> > offline the capabilities are not initialized and thus we'd report the
> > wrong error.
> > 
> > https://bugzilla.redhat.com/show_bug.cgi?id=1812531
> > 
> > Signed-off-by: Peter Krempa <pkrempa@xxxxxxxxxx>
> > ---
> >   src/qemu/qemu_checkpoint.c | 8 ++++----
> >   1 file changed, 4 insertions(+), 4 deletions(-)
> 
> We just did the same thing for CheckpointDelete :)

I noticed too late that there's another instance :)

> 
> Reviewed-by: Eric Blake <eblake@xxxxxxxxxx>

Thanks





[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux