Re: [libvirt PATCH v3 12/12] gitlab: add explicit early job for syntax-check

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Mar 26, 2020 at 03:41:14PM +0100, Andrea Bolognani wrote:
> On Thu, 2020-03-26 at 12:35 +0000, Daniel P. Berrangé wrote:
> [...]
> > +codestyle:
>
> check-codestlye, maybe?
>
> > +  stage: prebuild
> > +  script:
> > +    - mkdir build
> > +    - cd build
> > +    - ../autogen.sh --prefix=$(pwd)/../vroot || (cat config.log && exit 1)
>
> Setting --prefix is not necessary for this job.
>
> With that dropped,
>
>   Reviewed-by: Andrea Bolognani <abologna@xxxxxxxxxx>
>

Reviewed-by: Erik Skultety <eskultet@xxxxxxxxxx>

--
Erik Skultety





[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux