Re: [PATCH 5/9] qemuDomainGetMachineName: Access embeddedRoot from driver rather than cfg

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2020-03-25 at 11:18 +0100, Michal Privoznik wrote:
> The cfg->root is going away, therefore get the info right from
> the driver structure.
> 
> Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx>
> ---
>  src/qemu/qemu_domain.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Andrea Bolognani <abologna@xxxxxxxxxx>

Note that, even after this patch, there are multiple cases where
drv->embeddedRoot is accessed directly instead of going through
virQEMUDriverGetEmbedRoot(). Can you please post a separate patch
taking care of that?

-- 
Andrea Bolognani / Red Hat / Virtualization




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux