On 24. 3. 2020 17:14, Rafael Fonseca wrote: > The logic setting a device default should be in the post parse function > of individual driver code, not in `src/conf/domain_conf.c`. > > Rafael Fonseca (7): > bhyve: move video default logic to driver > libxl: move video default logic to driver > vz: openvz: move video default logic to driver > vmx: vmware: move video default logic to driver > test: move video default logic to driver > vbox: move video default logic to driver > conf: domain_conf: remove virDomainVideoDefaultType > > src/bhyve/bhyve_domain.c | 5 ++++ > src/conf/domain_conf.c | 52 +++------------------------------ > src/conf/domain_conf.h | 1 - > src/libvirt_private.syms | 1 - > src/libxl/libxl_domain.c | 60 +++++++++++++++++++++++--------------- > src/openvz/openvz_conf.c | 8 +++++ > src/test/test_driver.c | 23 +++++++++++++++ > src/vbox/vbox_common.c | 16 ++++++++++ > src/vmware/vmware_driver.c | 4 +++ > src/vmx/vmx.c | 4 +++ > src/vz/vz_driver.c | 8 +++++ > 11 files changed, 108 insertions(+), 74 deletions(-) > Reviewed-by: Michal Privoznik <mprivozn@xxxxxxxxxx> and pushed. Nice cleanup. Michal