On Tue, Mar 24, 2020 at 06:26:15PM +0100, Andrea Bolognani wrote: > On Tue, 2020-03-24 at 16:23 +0000, Daniel P. Berrangé wrote: > > Run the bare minimum build that is possible to create the docs. Ideally > > the '--without-remote' arg would be passed, but there are several bugs > > preventing a build from succeeding without the remote driver built. > > This comment is no longer necessary, is it? > > [...] > > +# This artifact published by this job is downloaded by libvirt.org to > > +# be deployed to the web root: > > +# https://gitlab.com/libvirt/libvirt/-/jobs/artifacts/master/download?job=website > > +website: > > + script: > > + - mkdir build > > + - cd build > > + - ../autogen.sh --prefix=$(pwd)/../vroot || (cat config.log && exit 1) > > + - make -j $(getconf _NPROCESSORS_ONLN) -C docs > > + - make -j $(getconf _NPROCESSORS_ONLN) -C docs install > > Can you please make patch 7/9 the first in the series, so that you > don't need to go back and change this to $MAKE later? I concur. > > > + - cd .. > > + - mv vroot/share/doc/libvirt/html/ website > > + image: quay.io/libvirt/buildenv-libvirt-fedora-31:latest > > Since the build job is running on Fedora 31 (at the moment), would > it make sense to call it website-fedora-31? The name of the artifact > would remain the same, so eg. the cron job we're going to have on > libvirt.org will not need to be modified every time we bump this. The website job is generic, meaning we don't care which distro it is being run on, so I'd rather not force the naming conventionby including the distro name. Reviewed-by: Erik Skultety <eskultet@xxxxxxxxxx>
