On Tue, 2020-03-24 at 10:22 -0300, Daniel Henrique Barboza wrote: > On 3/23/20 2:45 PM, Andrea Bolognani wrote: > > On Mon, 2020-03-23 at 14:21 -0300, Daniel Henrique Barboza wrote: > > > And while we're at it, something that just occurred to me, I'll also gate the ppc64 > > > only capabilities as well in a new patch. > > > > Yeah, that makes sense too. We're probably never going to get to a > > point where these checks are completely accurate, but any improvement > > can only be a welcome one :) > > Just realized that we're already doing that here: > > case VIR_DOMAIN_FEATURE_HPT: > case VIR_DOMAIN_FEATURE_HTM: > case VIR_DOMAIN_FEATURE_NESTED_HV: > case VIR_DOMAIN_FEATURE_CCF_ASSIST: > if (qemuDomainDefValidatePSeriesFeature(def, qemuCaps, i) < 0) > return -1; > break; Right! I had forgotten about writing that validation logic O:-) > There is no need for an extra patch to handle it. Nope, we're good :) -- Andrea Bolognani / Red Hat / Virtualization
