On 23. 3. 2020 17:56, Ján Tomko wrote:
> On a Monday in 2020, Michal Prívozník wrote:
>> On 23. 3. 2020 17:10, Ján Tomko wrote:
>>> As Dave pointed out, someone creative might name a domain
>>> to make its logfile conflict with a logfile of another
>>> domain's virtiofsd log.
>>>
>>> Signed-off-by: Ján Tomko <jtomko@xxxxxxxxxx>
>>> Reported-by: Dr. David Alan Gilbert <dgilbert@xxxxxxxxxx>
>>> ---
>>> src/qemu/qemu_virtiofs.c | 4 ++--
>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/src/qemu/qemu_virtiofs.c b/src/qemu/qemu_virtiofs.c
>>> index aaa25bcbb8..575b47fd74 100644
>>> --- a/src/qemu/qemu_virtiofs.c
>>> +++ b/src/qemu/qemu_virtiofs.c
>>> @@ -67,9 +67,9 @@
>>> qemuVirtioFSCreateLogFilename(virQEMUDriverConfigPtr cfg,
>>> {
>>> g_autofree char *name = NULL;
>>>
>>> - name = g_strdup_printf("%s-%s", def->name, alias);
>>> + name = g_strdup_printf("%s-%s.log.fs", def->name, alias);
>>>
>>> - return virFileBuildPath(cfg->logDir, name, "-virtiofsd.log");
>>> + return virFileBuildPath(cfg->logDir, name, NULL);
>>> }
>>>
>>>
>>>
>>
>> Why not go with virDomainDefGetShortName() then? Using def->name to name
>> a file is dangerous anyways.
>
> Other than path name limits (which are way higher than unix socket
> limits), it should not be dangerous.
>
>> Oh, is it because we want to keep the same
>> log name across domain cold reboots?
>>
>
> That too.
Okay, for whole series:
Reviewed-by: Michal Privoznik <mprivozn@xxxxxxxxxx>
Michal
