On Thu, Mar 19, 2020 at 12:05:17PM +0100, Pino Toscano wrote: > Since the removal of gnulib, HAVE_SOCKETPAIR is no more defined, making > these two tests effectively skipped. Doh, I had compared the config.h file before & after gnulib removal to identify HAVE_* macros that no longer existed, but guess I missed this. > > Use the same strategy used in other generic library bits, i.e. exclude > the socketpair usage on Windows. > > Semi-related change in virnetdaemontest.c to make it build: since > virutil.h does not include unistd.h anymore, we need to include it. > > Signed-off-by: Pino Toscano <ptoscano@xxxxxxxxxx> > --- > tests/virnetdaemontest.c | 4 +++- > tests/virnetserverclienttest.c | 2 +- > 2 files changed, 4 insertions(+), 2 deletions(-) Reviewed-by: Daniel P. Berrangé <berrange@xxxxxxxxxx> Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
