On Tue, 17 Mar 2020 at 15:05, Daniel P. Berrangé <berrange@xxxxxxxxxx> wrote: > > On Tue, Mar 17, 2020 at 03:00:48PM +0000, Peter Maydell wrote: > > On Tue, 17 Mar 2020 at 14:57, Daniel P. Berrangé <berrange@xxxxxxxxxx> wrote: > > > I don't feel like -Wno-unused-function looses anything significant, as > > > the GCC builds will still be reporting unused functions which will > > > catch majority of cases. > > > > The most interesting difference is that clang will catch unused > > static inline functions which gcc does not. > > That's mostly just about dead code cruft detection IIUC. That code won't > make it into the binary if it isn't used. Indeed, but it's nice to have the dead code cruft detection. You can always mark the function as __attribute__((unused)) if you really mean that it might be present but not used. thanks -- PMM
