[PATCH 2/3] qemuBlockBitmapsHandleCommitFinish: Use proper variable to iterate

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



The function repeatedly checked the first element rather than interating
through the array.

Reported-by: Daniel P. Berrangé <berrange@xxxxxxxxxx>
Signed-off-by: Peter Krempa <pkrempa@xxxxxxxxxx>
---
 src/qemu/qemu_block.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/qemu/qemu_block.c b/src/qemu/qemu_block.c
index 115682c39d..f95ebb6fa7 100644
--- a/src/qemu/qemu_block.c
+++ b/src/qemu/qemu_block.c
@@ -3177,7 +3177,7 @@ qemuBlockBitmapsHandleCommitFinish(virStorageSourcePtr topsrc,
                     char **disabledbitmaps;

                     for (disabledbitmaps = disabledBitmapsBase; *disabledbitmaps; disabledbitmaps++) {
-                        if (STREQ(*disabledBitmapsBase, bitmap->name)) {
+                        if (STREQ(*disabledbitmaps, bitmap->name)) {
                             bitmapdata = g_new0(struct qemuBlockBitmapsHandleCommitData, 1);

                             bitmapdata->create = false;
-- 
2.24.1





[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux