On 10. 3. 2020 19:13, Daniel P. Berrangé wrote: > The virNodeDevice{Reset,ReAttach,Dettach} methods are a little > unusual because they are registered by the virt driver, but > use the virNodeDevicePtr object associated with the nodedev > driver. > > In the split daemon world, we tried to dispatch them to the > virnodedevd daemon which has no impl registered. Dispatching > them to the virt driver has some quirks, we need to ensure > we have two virNodeDevicePtr instances, once for the virConnectPtr > of the virt driver and one for the virConnectPtr of the nodedev > driver. > > Daniel P. Berrangé (3): > rpc: fix dispatch for node device APIs for virt drivers > rpc: avoid name lookup when dispatching node device APIs > qemu: lookup node device against nodedev driver before getting XML > > src/libxl/libxl_driver.c | 63 +++++++++++++++++++++++++++-- > src/qemu/qemu_driver.c | 63 +++++++++++++++++++++++++++-- > src/remote/remote_daemon_dispatch.c | 7 ++++ > src/rpc/gendispatch.pl | 10 ++++- > 4 files changed, 135 insertions(+), 8 deletions(-) > Reviewed-by: Michal Privoznik <mprivozn@xxxxxxxxxx> Michal