Re: [PATCH 05/12] qemuAgentGetUsers: Fix return value on success

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On a Monday in 2020, Peter Krempa wrote:
Return 0 on success as per documentation and due to the fact that
callers don't check the value.

-EPARSE

Return 0 on success to match the documentation.
The callers only check for negative values.


Signed-off-by: Peter Krempa <pkrempa@xxxxxxxxxx>
---
src/qemu/qemu_agent.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/qemu/qemu_agent.c b/src/qemu/qemu_agent.c
index bc5d57ab94..c55b989467 100644
--- a/src/qemu/qemu_agent.c
+++ b/src/qemu/qemu_agent.c
@@ -2406,7 +2406,7 @@ qemuAgentGetUsers(qemuAgentPtr agent,
            return -1;
    }

-    return ndata;
+    return 0;
}

/* Returns: 0 on success

Reviewed-by: Ján Tomko <jtomko@xxxxxxxxxx>

Jano

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux