RE: [PATCHv2 0/5] update tls files without restarting libvirtd

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Thank you, Daniel !
I appreciate that.

Signed-off-by: Zhang Bo <oscar.zhangbo@xxxxxxxxxx>
Signed-off-by: Wu Qingliang <wuqingliang4@xxxxxxxxxx>

> -----Original Message-----
> From: Daniel P. Berrangé [mailto:berrange@xxxxxxxxxx]
> Sent: Thursday, March 12, 2020 12:22 AM
> To: Zhangbo (Oscar) <oscar.zhangbo@xxxxxxxxxx>
> Cc: libvir-list@xxxxxxxxxx; dengkai (A) <dengkai1@xxxxxxxxxx>; wujing (O)
> <wujing42@xxxxxxxxxx>; wuqingliang <wuqingliang4@xxxxxxxxxx>
> Subject: Re: [PATCHv2 0/5] update tls files without restarting libvirtd
> 
> On Sat, Mar 07, 2020 at 07:30:59PM +0800, Zhang Bo wrote:
> > v1:
> > https://www.redhat.com/archives/libvir-list/2020-February/msg00370.htm
> > l
> >
> > v2:
> > according to Dienial's suggestion:
> > * update each tls file one time -> update all of them at one time
> > * forced to re-create the credentials object, rather than allowing
> >   to append to the original ones.
> 
> Aside from some minor mistakes this all looks fine code wise.
> 
> The commits, however, are missing the signed-off-by statement.
> This is required to indicate that you agree to the contribution policy at:
> 
>   https://developercertificate.org/
> 
> Assuming you're find with this, just reply to this mail with a Signed-off-by:
> YOUR NAME <YOUR@EMAIL> and I'll add this to the commit messages &
> push to git with the minor fixes.
> 
> Regards,
> Daniel
> --
> |: https://berrange.com      -o-
> https://www.flickr.com/photos/dberrange :|
> |: https://libvirt.org         -o-            https://fstop138.berrange.com :|
> |: https://entangle-photo.org    -o-
> https://www.instagram.com/dberrange :|






[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux