Re: [PATCH] virt-aa-helper: Fix build by including virutil.h

[Christian Ehrhardt <christian.ehrhardt@xxxxxxxxxxxxx>]

On Tue, Feb 25, 2020 at 12:36 AM Jim Fehlig <jfehlig@xxxxxxxx> wrote:

Commit fb01e1a44d missed including virutil.h, causing the following
compilation error

../../src/security/virt-aa-helper.c:1055:43: error: implicit declaration of
function 'virHostGetDRMRenderNode' [-Werror=implicit-function-declaration]
1055 |                 char *defaultRenderNode = virHostGetDRMRenderNode();

Signed-off-by: Jim Fehlig <jfehlig@xxxxxxxx>
---

Pushing under the build-breaker rule.

Thanks Jim,

it always built for me in all pre-tests which is odd.

Thanks for fixing it so fast! 

 

 src/security/virt-aa-helper.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/security/virt-aa-helper.c b/src/security/virt-aa-helper.c
index 6f36652c7c..b6f58efdea 100644
--- a/src/security/virt-aa-helper.c
+++ b/src/security/virt-aa-helper.c
@@ -41,6 +41,7 @@
 #include "virxml.h"
 #include "viruuid.h"
 #include "virusb.h"
+#include "virutil.h"
 #include "virpci.h"
 #include "virfile.h"
 #include "configmake.h"
--
2.25.0

--

Christian Ehrhardt
Staff Engineer, Ubuntu Server
Canonical Ltd