Re: [libvirt PATCH 0/7] tests: libxl: clean up test mocking

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2/22/20 7:25 AM, Ján Tomko wrote:
Refactor libxlDriverConfigNew to remove the need
for mocking virFilePath and add libxlDomainGetEmulatorType
to the mock to remove the need to invoke a binary
for nearly every domain we parse

Ján Tomko (7):
   testutilsxen: error out on initialization failure
   libxl: conf: move default keepalive settings to libxlDriverConfigNew
   libxl: StateInitialize: use g_autofree
   libxl: split out DriverConfigInit out of DriverConfigNew
   libxl: do not mock virFileMakePath
   tests: link the libxl tests with libxltestdriver.la
   tests: libxl: do not run the emulator

  src/libxl/libxl_capabilities.h |  3 +-
  src/libxl/libxl_conf.c         | 85 ++++++++++++++++++----------------
  src/libxl/libxl_conf.h         |  2 +
  src/libxl/libxl_driver.c       |  7 +--
  tests/Makefile.am              |  9 ++--
  tests/libxlmock.c              | 18 +++----
  tests/testutilsxen.c           |  9 +++-
  7 files changed, 75 insertions(+), 58 deletions(-)


For the series

Reviewed-by: Jim Fehlig <jfehlig@xxxxxxxx>

Regards,
Jim






[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux