Awesome, thank you! I'll try to address the remaining feedback when I get a chance. This work isn't exactly my primary job function so it's been more of a nights and weekends labor of love kind of thing. Thanks again for taking the time to review and push these patches! On Mon, Feb 24, 2020 at 1:07 PM Daniel P. Berrangé <berrange@xxxxxxxxxx> wrote: > > On Mon, Feb 24, 2020 at 01:46:12AM -0500, Ryan Moeller wrote: > > Rebased and updated from previous patch set to address feedback: > > > > * Tried to match local convention for subjects where obvious > > * Split patch 01 into two patches, with updated messages > > * Use g_autofree to fix use after free in conf/virnetworkobj > > * Add missing newline in one of the tests args files > > * Fix failing schema tests after schema change > > > > gmake check now reports no failing tests on FreeBSD for each patch. > > > > Ryan Moeller (12): > > bhyve: process: remove unneeded header > > conf: fix use after free > > bhyve: process: don't bother seeking to end of log > > bhyve: monitor: Make bhyveMonitor a virClass > > bhyve: monitor: refactor register/unregister > > bhyve: add hooks > > bhyve: add reboot support > > bhyve: command: refactor virBhyveProcessBuildBhyveCmd > > bhyve: parse_command: slot,bus,func -> bus,slot,func > > Thanks for the contribution, I've pushed these patches now > since they were independant of the remaining three. > > > > add hostdev handling for bhyve > > bhyve: command: enable booting from hostdevs > > Allow PCI functions up to 255 for PCI ARI > > Regards, > Daniel > -- > |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| > |: https://libvirt.org -o- https://fstop138.berrange.com :| > |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :| > -- Ryan Moeller iXsystems, Inc. OS Developer Email: ryan@xxxxxxxxxxxxx
