> I'm confused as to why that error can be fixed by removing an include. > If I recall correctly, we used to get that kind of error when using > gnulib's includes but not linking with gnulib. > > Was that on a clean build from a fresh checkout, or do you have some > leftover gnulib artefacts present? > At any rate, this header does not seem to be needed since > commit a1bd8d2546c3e469f6a5ce119fad7da1cd473db5 and can be removed, > I'm just confused about the commit message. This patch set was started several months ago, maybe this is no longer relevant. > Since the 'file' variable is only used once per scope, you can just > declare it as: > g_autofree char *file = NULL; > and remove all the VIR_FREE calls. Thanks for the suggestion. I'm not at all familiar with the mailing list workflow, can you instruct me how to submit an updated patch? -- Ryan Moeller iXsystems, Inc. OS Developer Email: ryan@xxxxxxxxxxxxx
