On 2/19/20 4:53 AM, Max Reitz wrote:
On 31.01.20 18:11, Eric Blake wrote:
ping
Do you want further review or is Ján’s sufficient for you?
Commit 0bc16997 has already landed, so no further review will show in
git history. But you're always welcome to raise issues that might result
in follow-up patches.
Also, I wonder whether it would make a good GSoC/Outreachy/... project
to add partition reading support to the raw block driver, or whether
that’s a bad idea. O:-)
Personally, I think that since nbdkit already provides a good partition
filter [1], any other implementation of a partition filter is duplicated
effort. The only reason to teach qemu how to access an arbitrary
partition is if it makes serving that arbitrary partition to a guest
more efficient than what is currently possible by pointing qemu at an
NBD server run by nbdkit with its partition filter. But in general, you
are more likely to want qemu to serve an entire disk image file to the
guest (and let the guest interpret partitions embedded within that file)
than to have qemu serve a single partition to a guest (and have the
guest treat that partition as a bare disk), so I don't see it as
something that would be frequently used or needed in qemu.
[1] http://libguestfs.org/nbdkit-partition-filter.1.html
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
