Few recent changes broke wrong, but apparently widely used configurations as used didn't really record the image format into the image. It turns out we can safely probe the image format in few limited circumstances which on the other hand should fix the majority of the problems. Please see patch 8/9 for further explanation. Peter Krempa (9): util: storagefile: Drop image format probing by file suffix virStorageFileGetMetadataRecurse: Remove impossible error report virStorageFileGetMetadataRecurse: Shuffle around assignment of backing chain depth virStorageFileGetMetadataRecurse: Expect NULL src->path virStorageFileGetMetadataRecurse: Use virHashHasEntry instead of fake pointers virStorageFileGetMetadataRecurse: Extract storage access virStorageFileGetMetadataRecurse: Remove 'cleanup' label virStorageFileGetMetadataRecurse: Allow format probing under special circumstances WIP: Add tool for probing images src/util/virstoragefile.c | 231 ++++++++++++++++++-------------------- tests/Makefile.am | 13 ++- tests/qemublockprobe.c | 130 +++++++++++++++++++++ 3 files changed, 251 insertions(+), 123 deletions(-) create mode 100644 tests/qemublockprobe.c -- 2.24.1